-
-
Notifications
You must be signed in to change notification settings - Fork 515
put Linux build files inside a folder before zipping #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@per1234 can you test if appImage is still working on linux? I' not 100% sure the appImage will do NOT check the zip sha as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Linux_X86-64_zip" build artifact has the perfect structure (files in a folder instead of in the root of the .zip).
As requested, I did a test of the IDE auto-update behavior after this change. I produced the following channel file to allow me to test this build as the update target in addition to testing it as the update base:
version: 99.0.1 files: - url: arduino-ide_2.0.0-rc4-snapshot-85f5d6f_Linux_64bit.AppImage sha512: 1YE6Y5/MegOgE9NlrO/PrPACPMrpC/5cuVJUOgY8xsYn+KcFpVNYtqKldMVPUEJKkEw1aBvlaPp0BzFeo4rYQg== size: 246645528 blockMapSize: 258989 path: arduino-ide_2.0.0-rc4-snapshot-85f5d6f_Linux_64bit.AppImage sha512: 1YE6Y5/MegOgE9NlrO/PrPACPMrpC/5cuVJUOgY8xsYn+KcFpVNYtqKldMVPUEJKkEw1aBvlaPp0BzFeo4rYQg== releaseDate: 2022年02月28日T03:10:27.201Z
It worked perfectly.
Thanks Alberto!
Motivation
When you download the Arduino IDE in zip format for Linux and extract it, a lot of the files will be extracted in that folder. If a user does that in the Downloads folder, they will find it overflooded with files.
Change description
Reintroduce a function in the packager script to add a folder on top of the zip build, but only when on Linux.
Reviewer checklist